1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685
//! A local task pool with proper shutdown
use std::{
any::Any,
future::Future,
ops::Deref,
pin::Pin,
sync::{
atomic::{AtomicBool, Ordering},
Arc,
},
};
use futures_lite::FutureExt;
use tokio::{
sync::{Notify, Semaphore},
task::{JoinError, JoinSet, LocalSet},
};
type BoxedFut<T = ()> = Pin<Box<dyn Future<Output = T>>>;
type SpawnFn<T = ()> = Box<dyn FnOnce() -> BoxedFut<T> + Send + 'static>;
enum Message {
/// Create a new task and execute it locally
Execute(SpawnFn),
/// Shutdown the thread after finishing all tasks
Finish,
}
/// A local task pool with proper shutdown
///
/// Unlike
/// [`LocalPoolHandle`](https://docs.rs/tokio-util/latest/tokio_util/task/struct.LocalPoolHandle.html),
/// this pool will join all its threads when dropped, ensuring that all Drop
/// implementations are run to completion.
///
/// On drop, this pool will immediately cancel all *tasks* that are currently
/// being executed, and will wait for all threads to finish executing their
/// loops before returning. This means that all drop implementations will be
/// able to run to completion before drop exits.
///
/// On [`LocalPool::finish`], this pool will notify all threads to shut down,
/// and then wait for all threads to finish executing their loops before
/// returning. This means that all currently executing tasks will be allowed to
/// run to completion.
///
/// The pool will install the [`tracing::Subscriber`] which was set on the current thread of
/// where it was created as the default subscriber in all spawned threads.
#[derive(Debug)]
pub struct LocalPool {
threads: Vec<std::thread::JoinHandle<()>>,
shutdown_sem: Arc<Semaphore>,
cancel_token: CancellationToken,
handle: LocalPoolHandle,
}
impl Deref for LocalPool {
type Target = LocalPoolHandle;
fn deref(&self) -> &Self::Target {
&self.handle
}
}
/// A handle to a [`LocalPool`]
#[derive(Debug, Clone)]
pub struct LocalPoolHandle {
/// The sender half of the channel used to send tasks to the pool
send: async_channel::Sender<Message>,
}
/// What to do when a panic occurs in a pool thread
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum PanicMode {
/// Log the panic and continue
///
/// The panic will be re-thrown when the pool is dropped.
LogAndContinue,
/// Log the panic and immediately shut down the pool.
///
/// The panic will be re-thrown when the pool is dropped.
Shutdown,
}
/// Local task pool configuration
#[derive(Clone, Debug)]
pub struct Config {
/// Number of threads in the pool
pub threads: usize,
/// Prefix for thread names
pub thread_name_prefix: &'static str,
/// Ignore panics in pool threads
pub panic_mode: PanicMode,
}
impl Default for Config {
fn default() -> Self {
Self {
threads: num_cpus::get(),
thread_name_prefix: "local-pool",
panic_mode: PanicMode::Shutdown,
}
}
}
impl Default for LocalPool {
fn default() -> Self {
Self::new(Default::default())
}
}
impl LocalPool {
/// Create a new local pool with a single std thread.
pub fn single() -> Self {
Self::new(Config {
threads: 1,
..Default::default()
})
}
/// Create a new local pool with the given config.
///
/// This will use the current tokio runtime handle, so it must be called
/// from within a tokio runtime.
pub fn new(config: Config) -> Self {
let Config {
threads,
thread_name_prefix,
panic_mode,
} = config;
let cancel_token = CancellationToken::new();
let (send, recv) = async_channel::unbounded::<Message>();
let shutdown_sem = Arc::new(Semaphore::new(0));
let handle = tokio::runtime::Handle::current();
let handles = (0..threads)
.map(|i| {
Self::spawn_pool_thread(
format!("{thread_name_prefix}-{i}"),
recv.clone(),
cancel_token.clone(),
panic_mode,
shutdown_sem.clone(),
handle.clone(),
)
})
.collect::<std::io::Result<Vec<_>>>()
.expect("invalid thread name");
Self {
threads: handles,
handle: LocalPoolHandle { send },
cancel_token,
shutdown_sem,
}
}
/// Get a cheaply cloneable handle to the pool
///
/// This is not strictly necessary since we implement deref for
/// LocalPoolHandle, but makes getting a handle more explicit.
pub fn handle(&self) -> &LocalPoolHandle {
&self.handle
}
/// Spawn a new pool thread.
fn spawn_pool_thread(
thread_name: String,
recv: async_channel::Receiver<Message>,
cancel_token: CancellationToken,
panic_mode: PanicMode,
shutdown_sem: Arc<Semaphore>,
handle: tokio::runtime::Handle,
) -> std::io::Result<std::thread::JoinHandle<()>> {
let tracing_dispatcher = tracing::dispatcher::get_default(|dispatcher| dispatcher.clone());
std::thread::Builder::new()
.name(thread_name)
.spawn(move || {
let _tracing_guard = tracing::dispatcher::set_default(&tracing_dispatcher);
let mut s = JoinSet::new();
let mut last_panic = None;
let mut handle_join = |res: Option<std::result::Result<(), JoinError>>| -> bool {
if let Some(Err(e)) = res {
if let Ok(panic) = e.try_into_panic() {
let panic_info = get_panic_info(&panic);
let thread_name = get_thread_name();
tracing::error!(
"Panic in local pool thread: {}\n{}",
thread_name,
panic_info
);
last_panic = Some(panic);
}
}
panic_mode == PanicMode::LogAndContinue || last_panic.is_none()
};
let ls = LocalSet::new();
let shutdown_mode = handle.block_on(ls.run_until(async {
loop {
tokio::select! {
// poll the set of futures
res = s.join_next(), if !s.is_empty() => {
if !handle_join(res) {
break ShutdownMode::Stop;
}
},
// if the cancel token is cancelled, break the loop immediately
_ = cancel_token.cancelled() => break ShutdownMode::Stop,
// if we receive a message, execute it
msg = recv.recv() => {
match msg {
// just push into the join set
Ok(Message::Execute(f)) => {
s.spawn_local((f)());
}
// break with optional semaphore
Ok(Message::Finish) => break ShutdownMode::Finish,
// if the sender is dropped, break the loop immediately
Err(async_channel::RecvError) => break ShutdownMode::Stop,
}
},
}
}
}));
// soft shutdown mode is just like normal running, except that
// we don't add any more tasks and stop when there are no more
// tasks to run.
if shutdown_mode == ShutdownMode::Finish {
// somebody is asking for a clean shutdown, wait for all tasks to finish
handle.block_on(ls.run_until(async {
loop {
tokio::select! {
res = s.join_next() => {
if res.is_none() || !handle_join(res) {
break;
}
}
_ = cancel_token.cancelled() => break,
}
}
}));
}
// Always add the permit. If nobody is waiting for it, it does
// no harm.
shutdown_sem.add_permits(1);
if let Some(_panic) = last_panic {
// std::panic::resume_unwind(panic);
}
})
}
/// A future that resolves when the pool is cancelled
pub async fn cancelled(&self) {
self.cancel_token.cancelled().await
}
/// Immediately stop polling all tasks and wait for all threads to finish.
///
/// This is like drop, but waits for thread completion asynchronously.
///
/// If there was a panic on any of the threads, it will be re-thrown here.
pub async fn shutdown(self) {
self.cancel_token.cancel();
self.await_thread_completion().await;
// just make it explicit that this is where drop runs
drop(self);
}
/// Gently shut down the pool
///
/// Notifies all the pool threads to shut down and waits for them to finish.
///
/// If you just want to drop the pool without giving the threads a chance to
/// process their remaining tasks, just use [`Self::shutdown`].
///
/// If you want to wait for only a limited time for the tasks to finish,
/// you can race this function with a timeout.
pub async fn finish(self) {
// we assume that there are exactly as many threads as there are handles.
// also, we assume that the threads are still running.
for _ in 0..self.threads_u32() {
// send the shutdown message
// sending will fail if all threads are already finished, but
// in that case we don't need to do anything.
//
// Threads will add a permit in any case, so await_thread_completion
// will then immediately return.
self.send.send(Message::Finish).await.ok();
}
self.await_thread_completion().await;
}
fn threads_u32(&self) -> u32 {
self.threads
.len()
.try_into()
.expect("invalid number of threads")
}
async fn await_thread_completion(&self) {
// wait for all threads to finish.
// Each thread will add a permit to the semaphore.
let wait_for_semaphore = async move {
let _ = self
.shutdown_sem
.acquire_many(self.threads_u32())
.await
.expect("semaphore closed");
};
// race the semaphore wait with the cancel token in case somebody
// cancels the pool while we are waiting.
tokio::select! {
_ = wait_for_semaphore => {}
_ = self.cancel_token.cancelled() => {}
}
}
}
impl Drop for LocalPool {
fn drop(&mut self) {
self.cancel_token.cancel();
let current_thread_id = std::thread::current().id();
for handle in self.threads.drain(..) {
// we have no control over from where Drop is called, especially
// if the pool ends up in an Arc. So we need to check if we are
// dropping from within a pool thread and skip it in that case.
if handle.thread().id() == current_thread_id {
tracing::error!("Dropping LocalPool from within a pool thread.");
continue;
}
// Log any panics and resume them
if let Err(panic) = handle.join() {
let panic_info = get_panic_info(&panic);
let thread_name = get_thread_name();
tracing::error!("Error joining thread: {}\n{}", thread_name, panic_info);
// std::panic::resume_unwind(panic);
}
}
}
}
/// Errors for spawn failures
#[derive(thiserror::Error, Debug)]
pub enum SpawnError {
/// Task was dropped, either due to a panic or because the pool was shut down.
#[error("cancelled")]
Cancelled,
}
type SpawnResult<T> = std::result::Result<T, SpawnError>;
/// Future returned by [`LocalPoolHandle::spawn`] and [`LocalPoolHandle::try_spawn`].
///
/// Dropping this future will immediately cancel the task. The task can fail if
/// the pool is shut down or if the task panics. In both cases the future will
/// resolve to [`SpawnError::Cancelled`].
#[repr(transparent)]
#[derive(Debug)]
pub struct Run<T>(tokio::sync::oneshot::Receiver<T>);
impl<T> Run<T> {
/// Abort the task
///
/// Dropping the future will also abort the task.
pub fn abort(&mut self) {
self.0.close();
}
}
impl<T> Future for Run<T> {
type Output = std::result::Result<T, SpawnError>;
fn poll(
mut self: Pin<&mut Self>,
cx: &mut std::task::Context<'_>,
) -> std::task::Poll<Self::Output> {
// map a RecvError (other side was dropped) to a SpawnError::Shutdown
//
// The only way the receiver can be dropped is if the pool is shut down.
self.0.poll(cx).map_err(|_| SpawnError::Cancelled)
}
}
impl From<SpawnError> for std::io::Error {
fn from(e: SpawnError) -> Self {
std::io::Error::new(std::io::ErrorKind::Other, e)
}
}
impl LocalPoolHandle {
/// Get the number of tasks in the queue
///
/// This is *not* the number of tasks being executed, but the number of
/// tasks waiting to be scheduled for execution. If this number is high,
/// it indicates that the pool is very busy.
///
/// You might want to use this to throttle or reject requests.
pub fn waiting_tasks(&self) -> usize {
self.send.len()
}
/// Spawn a task in the pool and return a future that resolves when the task
/// is done.
///
/// If you don't care about the result, prefer [`LocalPoolHandle::spawn_detached`]
/// since it is more efficient.
pub fn try_spawn<T, F, Fut>(&self, gen: F) -> SpawnResult<Run<T>>
where
F: FnOnce() -> Fut + Send + 'static,
Fut: Future<Output = T> + 'static,
T: Send + 'static,
{
let (mut send_res, recv_res) = tokio::sync::oneshot::channel();
let item = move || async move {
let fut = (gen)();
tokio::select! {
// send the result to the receiver
res = fut => { send_res.send(res).ok(); }
// immediately stop the task if the receiver is dropped
_ = send_res.closed() => {}
}
};
self.try_spawn_detached(item)?;
Ok(Run(recv_res))
}
/// Spawn a task in the pool.
///
/// The task will run to completion unless the pool is shut down or the task
/// panics. In case of panic, the pool will either log the panic and continue
/// or immediately shut down, depending on the [`PanicMode`].
pub fn try_spawn_detached<F, Fut>(&self, gen: F) -> SpawnResult<()>
where
F: FnOnce() -> Fut + Send + 'static,
Fut: Future<Output = ()> + 'static,
{
let gen: SpawnFn = Box::new(move || Box::pin(gen()));
self.try_spawn_detached_boxed(gen)
}
/// Spawn a task in the pool and await the result.
///
/// Like [`LocalPoolHandle::try_spawn`], but panics if the pool is shut down.
pub fn spawn<T, F, Fut>(&self, gen: F) -> Run<T>
where
F: FnOnce() -> Fut + Send + 'static,
Fut: Future<Output = T> + 'static,
T: Send + 'static,
{
self.try_spawn(gen).expect("pool is shut down")
}
/// Spawn a task in the pool.
///
/// Like [`LocalPoolHandle::try_spawn_detached`], but panics if the pool is shut down.
pub fn spawn_detached<F, Fut>(&self, gen: F)
where
F: FnOnce() -> Fut + Send + 'static,
Fut: Future<Output = ()> + 'static,
{
self.try_spawn_detached(gen).expect("pool is shut down")
}
/// Spawn a task in the pool.
///
/// This is like [`LocalPoolHandle::try_spawn_detached`], but assuming that the
/// generator function is already boxed. This is the lowest overhead way to
/// spawn a task in the pool.
pub fn try_spawn_detached_boxed(&self, gen: SpawnFn) -> SpawnResult<()> {
self.send
.send_blocking(Message::Execute(gen))
.map_err(|_| SpawnError::Cancelled)
}
}
/// Thread shutdown mode
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
enum ShutdownMode {
/// Finish all tasks and then stop
Finish,
/// Stop immediately
Stop,
}
fn get_panic_info(panic: &Box<dyn Any + Send>) -> String {
if let Some(s) = panic.downcast_ref::<&str>() {
s.to_string()
} else if let Some(s) = panic.downcast_ref::<String>() {
s.clone()
} else {
"Panic info unavailable".to_string()
}
}
fn get_thread_name() -> String {
std::thread::current()
.name()
.unwrap_or("unnamed")
.to_string()
}
/// A lightweight cancellation token
#[derive(Debug, Clone)]
struct CancellationToken {
inner: Arc<CancellationTokenInner>,
}
#[derive(Debug)]
struct CancellationTokenInner {
is_cancelled: AtomicBool,
notify: Notify,
}
impl CancellationToken {
fn new() -> Self {
Self {
inner: Arc::new(CancellationTokenInner {
is_cancelled: AtomicBool::new(false),
notify: Notify::new(),
}),
}
}
fn cancel(&self) {
if !self.inner.is_cancelled.swap(true, Ordering::SeqCst) {
self.inner.notify.notify_waiters();
}
}
async fn cancelled(&self) {
if self.is_cancelled() {
return;
}
// Wait for notification if not cancelled
self.inner.notify.notified().await;
}
fn is_cancelled(&self) -> bool {
self.inner.is_cancelled.load(Ordering::SeqCst)
}
}
#[cfg(test)]
mod tests {
use std::{sync::atomic::AtomicU64, time::Duration};
use tracing::info;
use super::*;
/// A struct that simulates a long running drop operation
#[derive(Debug)]
struct TestDrop(Option<Arc<AtomicU64>>);
impl Drop for TestDrop {
fn drop(&mut self) {
// delay to make sure the drop is executed completely
std::thread::sleep(Duration::from_millis(100));
// increment the drop counter
if let Some(counter) = self.0.take() {
counter.fetch_add(1, std::sync::atomic::Ordering::SeqCst);
}
}
}
impl TestDrop {
fn new(counter: Arc<AtomicU64>) -> Self {
Self(Some(counter))
}
fn forget(mut self) {
self.0.take();
}
}
/// Create a non-send test future that captures a TestDrop instance
async fn delay_then_drop(x: TestDrop) {
tokio::time::sleep(Duration::from_millis(100)).await;
// drop x at the end. we will never get here when the future is
// no longer polled, but drop should still be called
drop(x);
}
/// Use a TestDrop instance to test cancellation
async fn delay_then_forget(x: TestDrop, delay: Duration) {
tokio::time::sleep(delay).await;
x.forget();
}
#[tokio::test]
async fn test_tracing() {
// This test wants to make sure that logging inside the pool propagates to the
// tracing subscriber that was set for the current thread at the time the pool was
// created.
//
// Look, there should be a custom tracing subscriber here that allows us to inspect
// the messages sent to it so we can verify it received all the messages. But have
// you ever tried to implement a tracing subscriber? In the mean time this test will
// just always pass, to really see the test run it with:
//
// cargo nextest run -p iroh-blobs local_pool::tests::test_tracing --success-output final
//
// and eyeball the output. yolo
let _guard = iroh_test::logging::setup();
info!("hello from the test");
let pool = LocalPool::single();
pool.spawn(|| async move {
info!("hello from the pool");
})
.await
.unwrap();
}
#[tokio::test]
async fn test_drop() {
let _ = tracing_subscriber::fmt::try_init();
let pool = LocalPool::new(Config::default());
let counter = Arc::new(AtomicU64::new(0));
let n = 4;
for _ in 0..n {
let td = TestDrop::new(counter.clone());
pool.spawn_detached(move || delay_then_drop(td));
}
drop(pool);
assert_eq!(counter.load(std::sync::atomic::Ordering::SeqCst), n);
}
#[tokio::test]
async fn test_finish() {
let _ = tracing_subscriber::fmt::try_init();
let pool = LocalPool::new(Config::default());
let counter = Arc::new(AtomicU64::new(0));
let n = 4;
for _ in 0..n {
let td = TestDrop::new(counter.clone());
pool.spawn_detached(move || delay_then_drop(td));
}
pool.finish().await;
assert_eq!(counter.load(std::sync::atomic::Ordering::SeqCst), n);
}
#[tokio::test]
async fn test_cancel() {
let _ = tracing_subscriber::fmt::try_init();
let pool = LocalPool::new(Config {
threads: 2,
..Config::default()
});
let c1 = Arc::new(AtomicU64::new(0));
let td1 = TestDrop::new(c1.clone());
let handle = pool.spawn(move || {
// this one will be aborted anyway, so use a long delay to make sure
// that it does not accidentally run to completion
delay_then_forget(td1, Duration::from_secs(10))
});
drop(handle);
let c2 = Arc::new(AtomicU64::new(0));
let td2 = TestDrop::new(c2.clone());
let _handle = pool.spawn(move || {
// this one will not be aborted, so use a short delay so the test
// does not take too long
delay_then_forget(td2, Duration::from_millis(100))
});
pool.finish().await;
// c1 will be aborted, so drop will run before forget, so the counter will be increased
assert_eq!(c1.load(std::sync::atomic::Ordering::SeqCst), 1);
// c2 will not be aborted, so drop will run after forget, so the counter will not be increased
assert_eq!(c2.load(std::sync::atomic::Ordering::SeqCst), 0);
}
// #[tokio::test]
// #[should_panic]
// #[ignore = "todo"]
// async fn test_panic() {
// let _ = tracing_subscriber::fmt::try_init();
// let pool = LocalPool::new(Config {
// threads: 2,
// ..Config::default()
// });
// pool.spawn_detached(|| async {
// panic!("test panic");
// });
// // we can't use shutdown here, because we need to allow time for the
// // panic to happen.
// pool.finish().await;
// }
}